Created a testcase for auto primary content #460
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
16715a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df4b1211.emseapi.pages.dev |
| Branch Preview URL: | https://almp-620.emseapi.pages.dev |
Codecov Report
@@ Coverage Diff @@
## dev #460 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 33 33
Lines 4834 4834
Branches 32 32
=======================================
Hits 4436 4436
Misses 384 384
Partials 14 14 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chef-danny-d
requested changes
Mar 15, 2023
| coll.map((c) => { | ||
| c.lessons.map((lesson) => { | ||
| if (lesson.content.length == 1) | ||
| expect(lesson.content[0].primary).toBe(true); |
There was a problem hiding this comment.
We are expecting the lesson's first content to be primary if the array length is 1.
- What is this test cases checking if the content length is more then 1?
- Is this test case covering creating content with a primary conflict?
- Is this test case covering updating content to be primary where there already is a primary in the Array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.